-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional filtering to LLM Engines #1550
Closed
dagardner-nv
wants to merge
53
commits into
nv-morpheus:branch-24.06
from
dagardner-nv:david-please-just-work
Closed
Add optional filtering to LLM Engines #1550
dagardner-nv
wants to merge
53
commits into
nv-morpheus:branch-24.06
from
dagardner-nv:david-please-just-work
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into messagemeta-get-dataframe-update
…into messagemeta-get-dataframe-update
…o-nv/Morpheus into david-please-just-work
…o-nv/Morpheus into david-please-just-work
dagardner-nv
added
non-breaking
Non-breaking change
DO NOT MERGE
PR should not be merged; see PR for details
sherlock
Issues/PRs related to Sherlock workflows and components
skip-ci
Optionally Skip CI for this PR
labels
Mar 6, 2024
…into messagemeta-get-dataframe-update
…into messagemeta-get-dataframe-update
…into messagemeta-get-dataframe-update
…into messagemeta-get-dataframe-update
…o-nv/Morpheus into david-please-just-work
…avid-please-just-work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
DO NOT MERGE
PR should not be merged; see PR for details
non-breaking
Non-breaking change
sherlock
Issues/PRs related to Sherlock workflows and components
skip-ci
Optionally Skip CI for this PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an optional
filter_fn
constructor argument toExtracterNode
If defined the
filter_fn
receives aDataFrame
and returns alist[bool]
mask to indicate which rows the LLM Engine should operate on. The mask will be saved into the LLM Context, the task handler then re-applies the mask to set the correct output rowsThis is different than our current
FilterDetectionsStage
impl in a few key ways:FilterDetectionsStage
is to exclude certain rows from the output.FilterDetectionsStage
filteres according to a thresholdFilterDetectionsStage
is specific toMultiMessage
and it's slice operations.Includes code changes from PRs #1538 & #1544
The changes specific to this PR are in :
morpheus/_lib/include/morpheus/llm/llm_context.hpp
morpheus/_lib/src/llm/llm_context.cpp
morpheus/_lib/llm/module.cpp
morpheus/llm/nodes/extracter_node.py
morpheus/llm/task_handlers/simple_task_handler.py
By Submitting this PR I confirm: